Hi Rob,
Thanks a lot for the review!
On 30/11/2018 3:51 PM, Rob Herring wrote:
On Mon, Nov 5, 2018 at 1:41 PM Daniel Mack <daniel@xxxxxxxxxx> wrote:
+ compatible = "spi-gpio";
+ #address-cells = <0x1>;
+ #size-cells = <0>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&spi_pins>;
+ gpio-sck = <&gpio 95 GPIO_ACTIVE_HIGH>;
+ gpio-miso = <&gpio 98 GPIO_ACTIVE_HIGH>;
+ gpio-mosi = <&gpio 97 GPIO_ACTIVE_HIGH>;
+ cs-gpios = <
+ &gpio 34 GPIO_ACTIVE_HIGH
+ &gpio 125 GPIO_ACTIVE_HIGH
+ &gpio 96 GPIO_ACTIVE_HIGH
+ >;
+ num-chipselects = <3>;
Why do we have this when we can just get the length of cs-gpios?
That's a good question, but for now, the driver requires the node to be
there. It can probably be cleaned up by a separate series.
+&pwri2c {
+ status = "okay";
+
+ max8660: regulator@34 {
+ compatible = "maxim,max8660";
+ reg = <0x34>;
+
+ regulators {
+ regulator@0 {
Drop the unit-address as there is no reg property. Build your DT with
W=12 and fix any new warnings these new files add (probably some are
from the SoC dtsi).
This hint helped a lot. I've fixed numerous smaller problems in the SoC
dtsi and will submit them together with a v2 of this patch.
Best regards,
Daniel
