Hi Biju, On Tue, Nov 27, 2018 at 1:05 PM Biju Das <biju.das@xxxxxxxxxxxxxx> wrote: > Add du node to r8a7744 SoC DT. Boards that want to enable the DU > need to specify the output topology. > > Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx> Thanks for your patch! > --- a/arch/arm/boot/dts/r8a7744.dtsi > +++ b/arch/arm/boot/dts/r8a7744.dtsi > @@ -1300,8 +1300,17 @@ > }; > > du: display@feb00000 { > + compatible = "renesas,du-r8a7744"; > reg = <0 0xfeb00000 0 0x40000>, > <0 0xfeb90000 0 0x1c>; > + reg-names = "du", "lvds.0"; Please use the new DU/LVDS bindings, using a separate node for LVDS. BTW, I believe the display won't work with a recent tree, unless you've added a DT live patch drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7744.dts? The same is true for RZ/G1M. > + interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 724>, > + <&cpg CPG_MOD 723>, > + <&cpg CPG_MOD 726>; > + clock-names = "du.0", "du.1", "lvds.0"; > + status = "disabled"; > > ports { > #address-cells = <1>; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds