Hi Manivannan, On 2018/10/31 13:38, Linus Walleij wrote: > On Mon, Oct 29, 2018 at 10:43 AM Manivannan Sadhasivam > <manivannan.sadhasivam@xxxxxxxxxx> wrote: > >> This patchset standardizes the onboard LEDs on 96Boards by maintaining >> common labels and triggers as below: >> >> green:user1 default-trigger: heartbeat >> green:user2 default-trigger: mmc0/disk-activity (onboard-storage) >> green:user3 default-trigger: mmc1 (SD card) >> green:user4 default-trigger: none, panic-indicator >> yellow:wlan default-trigger: phy0tx >> blue:bt default-trigger: hci0-power >> >> This standardization is required to provide a common behaviour of LEDs >> across all mainline supported 96Boards and also making it easier to >> control it using an userspace library like MRAA. >> >> For Rock960 and Ficus boards, the LED support is added in this patchset. >> Rest of the boards are converted to adopt the standard. >> >> Note: Since there is no UFS trigger available for now, user2 LED trigger >> is set to none on HiKey960. > > This series: > Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > > It makes a lot of sense to try to unify the userspace ABI so we get > some kind of order here instead of trying to counteract it with > per-device kludges in userspace. It definately makes things better! > > Yours, > Linus Walleij > > . > Applied hisilicon part(patch 3,4 and 5) to the hisilicon soc dt tree. Thanks! Best Regards, Wei
