On Tue, Nov 27, 2018 at 11:56:15AM +0000, Biju Das wrote: > Add the I2C[0-5] and IIC[0,1,3] devices nodes to the R8A7744 device tree. > > Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx> > --- > arch/arm/boot/dts/r8a7744.dtsi | 141 ++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 139 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/r8a7744.dtsi b/arch/arm/boot/dts/r8a7744.dtsi > index 165c701..6505ebd 100644 > --- a/arch/arm/boot/dts/r8a7744.dtsi > +++ b/arch/arm/boot/dts/r8a7744.dtsi > @@ -15,6 +15,18 @@ > #address-cells = <2>; > #size-cells = <2>; > > + aliases { > + i2c0 = &i2c0; > + i2c1 = &i2c1; > + i2c2 = &i2c2; > + i2c3 = &i2c3; > + i2c4 = &i2c4; > + i2c5 = &i2c5; > + i2c6 = &iic0; > + i2c7 = &iic1; > + i2c8 = &iic3; > + }; > + I believe we are moving away from adding aliases such as those above. Geert, can you comment on this? Other than that this patch looks good to me. Reviewed-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>