Re: [PATCH 2/2] i2c: meson: add support for Meson G12A SoC I2C controller

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Neil,

On 2018/11/29 19:26, Neil Armstrong wrote:
On 29/11/2018 11:59, Jian Hu wrote:
Add compatible and data for G12A I2C controller.

Signed-off-by: Jian Hu <jian.hu@xxxxxxxxxxx>
---
  drivers/i2c/busses/i2c-meson.c | 5 +++++
  1 file changed, 5 insertions(+)

diff --git a/drivers/i2c/busses/i2c-meson.c b/drivers/i2c/busses/i2c-meson.c
index 90f5d04..b86eed7 100644
--- a/drivers/i2c/busses/i2c-meson.c
+++ b/drivers/i2c/busses/i2c-meson.c
@@ -462,10 +462,15 @@ static int meson_i2c_remove(struct platform_device *pdev)
  	.div_factor = 3,
  };
+static const struct meson_i2c_data i2c_g12a_data = {
+	.div_factor = 3,

Especially if the div_factor is the same as AXG.

If you have some other fixes for G12a in the pipe, you will add the new compatible and meson_i2c_data later,
for the div_factor, simply use the axg struct and compatible.

Neil

For axg and g12a SoC, the div_factor is the same, and I have confirmed that they share the same IP. I prefer g12a uses axg's compatible and data if it is reasonable. I will just submit the i2c controller node in meson-g12a.dtsi.
+};
+
  static const struct of_device_id meson_i2c_match[] = {
  	{ .compatible = "amlogic,meson6-i2c", .data = &i2c_meson6_data },
  	{ .compatible = "amlogic,meson-gxbb-i2c", .data = &i2c_gxbb_data },
  	{ .compatible = "amlogic,meson-axg-i2c", .data = &i2c_axg_data },
+	{ .compatible = "amlogic,meson-g12a-i2c", .data = &i2c_g12a_data },
  	{},
  };

.




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux