On Wed, Nov 21, 2018 at 10:07:03AM -0500, thesven73@xxxxxxxxx wrote: > Fieldbus device (client) adapters allow data exchange with a PLC aka. > "Fieldbus Controller" over a fieldbus (Profinet, FLNet, etc.) > > They are typically used when a Linux device wants to expose itself > as an actuator, motor, console light, switch, etc. over the fieldbus. > > This framework is designed to provide a generic interface to Fieldbus > Devices from both the Linux Kernel and the userspace. > > Signed-off-by: Sven Van Asbroeck <svendev@xxxxxxxx> License nit: > --- /dev/null > +++ b/drivers/fieldbus/dev_core.c > @@ -0,0 +1,355 @@ > +// SPDX-License-Identifier: GPL-2.0 That's great, but then you write: > +MODULE_LICENSE("GPL"); Which means "GPLv2+". So this MODULE_LICENSE() should be "GPL v2", right? thanks, greg k-h