On Mon, Nov 12, 2018 at 03:39:29AM +0100, Lubomir Rintel wrote: > HiMax HX8837 is a display controller used on OLPC platforms. It controls > backlight and is able to capture and freeze a frame when the LCD controller > (and the rest of the plaform) is powered off. > > This driver is based on the same code as drivers/staging/olpc_dcon. > I modernized it to use managed GPIO, device-tree bindings, sysfs attribtue > groups, essentially fixing the staging driver's TODO. You are creating custom sysfs files, with no Documentation/ABI/ update for us to know what those files are or how they are used :( Why do you need custom sysfs files in the first place? Isn't there already an api for this type of device in the kernel? thanks, greg k-h