Am Montag, 26. November 2018, 14:36:01 CET schrieb Otavio Salvador: > Hello Heiko, > > On Mon, Nov 26, 2018 at 3:59 AM Heiko Stuebner <heiko@xxxxxxxxx> wrote: > > Am Sonntag, 25. November 2018, 22:19:02 CET schrieb Otavio Salvador: > > > According to the Rockchip vendor tree the PMU interrupt number is > > > 76, so fix it accordingly. > > > > > > Signed-off-by: Otavio Salvador <otavio@xxxxxxxxxxxxxxxx> > > > Signed-off-by: Fabio Berton <fabio.berton@xxxxxxxxxxxxxxxx> > > > > looks ok, especially as the TRM I have doesn't list neither irqs :-) > > But please explain the second Signed-off by Fabio? > > > > If Fabio is the original author, the patch From should reflect that > > and the Signed-off-by lines should be swapped. As it is now > > I would expect Fabio being the one sending the patches. > > Or is it supposed to be a "Co-developed-by:"? > > See Documentation/process/5.Posting.rst. > > He works with me and he applied and tested it in our internal tree for > our customer. He reviewed and tested this with me, so I'd like to > provide him credit as well. Reviewed-by: Tested-by: perhaps then? :-) Heiko