On Tue, Mar 11, 2014 at 12:57:32PM +0200, Jyri Sarha wrote:
> This commit adds a bare bones driver support for TLV320AIC31XX family
> audio codecs. The driver adds basic stereo playback trough headphone
> and speaker outputs and mono capture trough microphone inputs.
Applied, thanks. One thing it'd be good to fix:
> +Optional properties:
> +
> +- gpio-reset - gpio pin number used for codec reset
> +- ai31xx-micbias-vg - MicBias Voltage setting
This is optional but...
> + of_property_read_u32(np, "ai31xx-micbias-vg", &value);
> + switch (value) {
> + case MICBIAS_2_0V:
> + case MICBIAS_2_5V:
> + case MICBIAS_AVDDV:
> + aic31xx->pdata.micbias_vg = value;
> + break;
> + default:
> + dev_err(aic31xx->dev,
> + "Bad ai31xx-micbias-vg value %d DT\n",
> + value);
> + aic31xx->pdata.micbias_vg = MICBIAS_2_0V;
> + }
...you'll get an error if it's missing (and an uninitialised memory
read).
Attachment:
signature.asc
Description: Digital signature
