On Fri, Nov 23, 2018 at 04:18:06PM +0100, Andrew Lunn wrote: > Russell King wrote a comphy driver for the Armada 3XX family. It only > supports network PHYs. Did you check it does the right thing when > passed PHY_MODE_SATA? This is slightly different to Hans's comment, in > that i expect phy_set_mode() is implemented for the comphy driver, but > it might not understand PHY_MODE_SATA and return an error? It makes no difference until the comphy is wired up to the SATA device in the appropriate DT files. Until then, there's no way that the comphy will ever see PHY_MODE_SATA. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up