Re: [PATCH 11/17] soc: ti: pruss: add pruss_get()/put() API

[Arnd Bergmann <arnd@xxxxxxxx>]

On Thu, Nov 22, 2018 at 12:41 PM Roger Quadros <rogerq@xxxxxx> wrote:

> +
> +       if (IS_ERR_OR_NULL(rproc))
> +               return ERR_PTR(-EINVAL);


Any usage of  IS_ERR_OR_NULL() tends to be an indication of a badly
designed API. Please change this to allow only one of the two to be passed
around.

       Arnd