On Tue, 2018-11-20 at 11:28 +0100, Matthias Brugger wrote: > > On 20/11/2018 09:41, Leilk Liu wrote: > > This patch adds a DT binding documentation for the MT7629 soc. > > > > Signed-off-by: Leilk Liu <leilk.liu@xxxxxxxxxxxx> > > --- > > .../devicetree/bindings/spi/spi-mt65xx.txt | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/spi/spi-mt65xx.txt b/Documentation/devicetree/bindings/spi/spi-mt65xx.txt > > index 7940940..6cc4e87 100644 > > --- a/Documentation/devicetree/bindings/spi/spi-mt65xx.txt > > +++ b/Documentation/devicetree/bindings/spi/spi-mt65xx.txt > > @@ -6,6 +6,7 @@ Required properties: > > - mediatek,mt2712-spi: for mt2712 platforms > > - mediatek,mt6589-spi: for mt6589 platforms > > - mediatek,mt7622-spi: for mt7622 platforms > > + - mediatek,mt7629-spi: for mt7629 platforms > > That's ok, as you add support in the driver. As it actually doesn't change > anything in the driver itself you could just describe the binding as something like: > " mediatek,mt7629-spi", "mediatek,mt7622-spi": for mt7629 platforms > > This way the driver will just probe the driver using the fallback (mt7622) > compatible, but if you realize in the future that you will need to distinguish > between the two SoCs, you can add a mt7629 compatible. > > Just as information for the future :) > Got it, thanks for your advice and information :) > Regards, > Matthias
