On Mon, Nov 19, 2018 at 2:00 PM Maxime Ripard <maxime.ripard@xxxxxxxxxxx> wrote: > > On Fri, Nov 16, 2018 at 10:09:07PM +0530, Jagan Teki wrote: > > Burst mode display timings are different from convectional > > video mode so update the horizontal and vertical timings. > > > > Reference code taken from BSP (from linux-sunxi/ > > drivers/video/sunxi/disp2/disp/de/lowlevel_sun50iw1/de_dsi.c) > > > > dsi_hsa = 0; > > dsi_hbp = 0; > > dsi_hact = x*dsi_pixel_bits[format]/8; > > dsi_hblk = dsi_hact; > > dsi_hfp = 0; > > dsi_vblk = 0; > > > > Signed-off-by: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx> > > How is that matching the code you have in the rest of your patch? + if (device->mode_flags & MIPI_DSI_MODE_VIDEO_BURST) + timings.hblk = (mode->hdisplay * Bpp); + else + sun6i_dsi_get_timings(dsi, mode, &timings); It's again your request to "keep the couple of function to make more readable"
