Hi Andrew,
On Sun, Nov 18, 2018 at 6:13 PM Andrew Lunn <andrew@xxxxxxx> wrote:
>
> Hi Martin
>
> > +static int ip101a_g_probe(struct phy_device *phydev)
> > +{
> > + struct device *dev = &phydev->mdio.dev;
> > + struct ip101a_g_phy_priv *priv;
> > +
> > + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> > + if (!priv)
> > + return -ENOMEM;
> > +
> > + if (device_property_read_bool(dev, "icplus,select-rx-error"))
> > + priv->sel_intr32 = IP101GR_SEL_INTR32_RXER;
> > + else if (device_property_read_bool(dev, "icplus,select-interrupt"))
> > + priv->sel_intr32 = IP101GR_SEL_INTR32_INTR;
> > + else
> > + priv->sel_intr32 = IP101GR_SEL_INTR32_KEEP;
>
> It would be good to return -EINVAL if both properties are found.
that makes sense
I'll wait a few days for more feedback and re-send this series with
that issue fixed
> This looks good otherwise.
great, thanks for looking into it!
Regards
Martin
