On Sat, Nov 17, 2018 at 07:20:05PM +0100, Martin Blumenstingl wrote: > The datasheet uses the name "All Mask" for this bit. Change the name of > our #define to be consistent with the datasheet. While here also replace > the tab between the #define and IP101A_G_IRQ_ALL_MASK with a space. > No functional changes. > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> I think this is the bit which confused Florian. Nice change, it makes it a lot clearer what is going on. Reviewed-by: Andrew Lunn <andrew@xxxxxxx> Andrew