Hi Neil, On Wed, Nov 14, 2018 at 2:16 PM Neil Armstrong <narmstrong@xxxxxxxxxxxx> wrote: > > The Amlogic Meson GX SoCs embeds a clock measurer IP to measure the internal > clock paths frequencies. I would skip the "GX" in that sentence: there's a similar (identical?) clock measurer in Meson6, Meson8, Meson8b and Meson8m2 as well > > Signed-off-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx> with the comment above and below: Acked-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> > --- > .../bindings/soc/amlogic/clk-measure.txt | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/amlogic/clk-measure.txt > > diff --git a/Documentation/devicetree/bindings/soc/amlogic/clk-measure.txt b/Documentation/devicetree/bindings/soc/amlogic/clk-measure.txt > new file mode 100644 > index 000000000000..ba9183a42032 > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/amlogic/clk-measure.txt > @@ -0,0 +1,15 @@ > +Amlogic Internal Clock Measurer > +=============================== > + > +The Amlogic SoCs contains an IP to measure the internal clocks. > +The precision is multiple of MHz, useful to debug the clock states. > + > +Required properties: > +- compatible: Shall contain "amlogic,meson-gx-clk-measure" can you please add "amlogic,meson8-clk-measure" and "amlogic,meson8b-clk-measure" as well? (I will provide a patch on top of yours to add Meson8 and Meson8b support) Regards Martin
