Hi Leo, > -----Original Message----- > From: Leo Li > Sent: 2018年11月15日 2:52 > To: Z.q. Hou <zhiqiang.hou@xxxxxxx>; linux-pci@xxxxxxxxxxxxxxx; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx; bhelgaas@xxxxxxxxxx; robh+dt@xxxxxxxxxx; > mark.rutland@xxxxxxx; l.subrahmanya@xxxxxxxxxxxxxx; > shawnguo@xxxxxxxxxx; lorenzo.pieralisi@xxxxxxx > Cc: Mingkai Hu <mingkai.hu@xxxxxxx>; M.h. Lian > <minghuan.lian@xxxxxxx>; Xiaowei Bao <xiaowei.bao@xxxxxxx> > Subject: RE: [PATCH 21/23] dt-bindings: pci: Add NXP LX SoCs PCIe controller > > > > > -----Original Message----- > > From: Z.q. Hou > > Sent: Sunday, November 11, 2018 5:48 PM > > To: Leo Li <leoyang.li@xxxxxxx>; linux-pci@xxxxxxxxxxxxxxx; linux-arm- > > kernel@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux- > > kernel@xxxxxxxxxxxxxxx; bhelgaas@xxxxxxxxxx; robh+dt@xxxxxxxxxx; > > mark.rutland@xxxxxxx; l.subrahmanya@xxxxxxxxxxxxxx; > > shawnguo@xxxxxxxxxx; lorenzo.pieralisi@xxxxxxx > > Cc: Mingkai Hu <mingkai.hu@xxxxxxx>; M.h. Lian > > <minghuan.lian@xxxxxxx>; Xiaowei Bao <xiaowei.bao@xxxxxxx> > > Subject: RE: [PATCH 21/23] dt-bindings: pci: Add NXP LX SoCs PCIe > > controller > > > > Hi Leo, > > > > Thanks a lot for your comments! > > > > > -----Original Message----- > > > From: Leo Li > > > Sent: 2018年11月9日 5:29 > > > To: Z.q. Hou <zhiqiang.hou@xxxxxxx>; linux-pci@xxxxxxxxxxxxxxx; > > > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; > > > linux-kernel@xxxxxxxxxxxxxxx; bhelgaas@xxxxxxxxxx; > > > robh+dt@xxxxxxxxxx; mark.rutland@xxxxxxx; > > > l.subrahmanya@xxxxxxxxxxxxxx; shawnguo@xxxxxxxxxx; > > > lorenzo.pieralisi@xxxxxxx > > > Cc: Mingkai Hu <mingkai.hu@xxxxxxx>; M.h. Lian > > > <minghuan.lian@xxxxxxx>; Xiaowei Bao <xiaowei.bao@xxxxxxx> > > > Subject: RE: [PATCH 21/23] dt-bindings: pci: Add NXP LX SoCs PCIe > > > controller > > > > > > > > > > > > > -----Original Message----- > > > > From: Z.q. Hou > > > > Sent: Tuesday, November 6, 2018 7:21 AM > > > > To: linux-pci@xxxxxxxxxxxxxxx; > > > > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; > > > > devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > > > > bhelgaas@xxxxxxxxxx; robh+dt@xxxxxxxxxx; mark.rutland@xxxxxxx; > > > > l.subrahmanya@xxxxxxxxxxxxxx; shawnguo@xxxxxxxxxx; Leo Li > > > > <leoyang.li@xxxxxxx>; lorenzo.pieralisi@xxxxxxx > > > > Cc: Mingkai Hu <mingkai.hu@xxxxxxx>; M.h. Lian > > > > <minghuan.lian@xxxxxxx>; Xiaowei Bao <xiaowei.bao@xxxxxxx>; Z.q. > > > Hou > > > > <zhiqiang.hou@xxxxxxx> > > > > Subject: [PATCH 21/23] dt-bindings: pci: Add NXP LX SoCs PCIe > > > > controller > > > > > > > > From: Hou Zhiqiang <Zhiqiang.Hou@xxxxxxx> > > > > > > > > Add PCIe controller DT bindings of NXP LX series SoCs. > > > > > > I'm not sure if this is a good idea to name this controller LX PCIe controller. > > > Right now, it could be true that it is only used on LX series SoCs. > > > But I'm not sure if the LS series will not use this controller or LX > > > series will only use this controller in the future. > > > > > > Since the LX series is still using the layerscape branding, so > > > probably we should keep using the layerscape-pci.txt and define the > > > PCIe > > Gen4 variant? > > > > Yes, will add the new PCIe IP bindings to Layerscape-pci.txt. > > > > > > > > Same comment for other places using the LX naming in this driver. > > > > Do you have any suggestion about how to name the driver and prefix of > > structures in the driver? > > Probably something like pcie-layerscape-gen4? Thanks for your suggestion! Thanks, Zhiqiang