On Wed, Nov 14, 2018 at 2:52 PM Chen-Yu Tsai <wens@xxxxxxxx> wrote: > > On Wed, Nov 14, 2018 at 2:58 PM Chen-Yu Tsai <wens@xxxxxxxx> wrote: > > > > On Wed, Nov 14, 2018 at 2:31 PM Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx> wrote: > > > > > > On Tue, Nov 13, 2018 at 5:52 PM Andre Przywara <andre.przywara@xxxxxxx> wrote: > > > > > > > > On Tue, 13 Nov 2018 16:46:32 +0530 > > > > Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx> wrote: > > > > > > > > Hi, > > > > > > > > > This patch add support for Bananapi S070WV20-CT16 DSI panel to > > > > > BPI-M64 board. > > > > > > > > > > DSI panel connected via board DSI port with, > > > > > - DC1SW as AVDD supply > > > > > > > > Are you sure of that? I don't see anything in the schematic to support > > > > this. The only power lines that go to the DSI connector are DCDC1 and > > > > PS. DC1SW is only connected to PortD on the SoC and to the Ethernet PHY. > > > > Is there anything I miss? > > > > > > Thanks for the comment, yes dc1sw is connected in ephy. I have reused > > > dc1, BSP is attached lcd_power1 to axp81x_dc1sw [1]. I just looking > > > for someone to comment, may be we can skip this regulator attachment. > > > > That seems sketchy. The schematics show the connector has feeds from both > > the unregulated output IPSOUT (PS) and DCDC1. For designs with RGB LCD > > panels, we only see the PS feed. Since the LCD panel can be used in either > > RGB or MIPI DSI mode, I highly suspect the DCDC1 supply feeds the bridge > > IC. > > > > As for DC1SW, this is likely referenced because it provides power to the > > GPIO lines that are used to control the LCD panel. If you don't provide > > power, you can't pull them up. > > > > While many of us dislike FEX and the new FEX-derived device tree, they > > do provide some information, such as regulator usage. Note that each > > regulator output has multiple names, which likely denote specific > > usages. > > > > I've asked BPI for schematics on the bridge board. Hopefully we'll > > have something in more detail. In the meantime, I suggest leaving > > this panel out of your next submission, and focus on getting the bulk > > of the dsi driver and dts changes in first. > > I got the schematics, but unfortunately I can't share them publicly. > > It looks like VCC-MIPI on the connector is not connected to anything. > All power is provided from IPSOUT, first through a current limiter IC > turned on and off by LCD_PWR_EN, and then through some voltage regulators > to provide the voltages for various parts of the panel, including LCD, > capacitive touch, and the MIPI-DSI bridge. There's even an onboard EEPROM, > though I'm not sure what that's for. So there is no concern supply regulators on panel side, only VCC-DSI. > > > > > > > > > > > > > - DCDC1 as DVDD supply > > > > > > > > That seems right, but doesn't match with what you write below. > > > > > > Commit need to fix s/DCDC1/DLDO1 > > > > > > > > > > > > - PD6 gpio for reset pin > > This toggles reset for both the panel itself and for the MIPI-DSI bridge. > > > > > > - PD5 gpio for backlight enable pin > > This enables the backlight's regulator. > > > > > > - PD7 gpio for backlight vdd supply > > This enables power to the whole panel module. > > Then you also have the two GPIOs for the capacitive touch controller. > And also the I2C bus for the controller, and the EEPROM. Thanks, for the details. I have verified w/ vcc-dsi-supply attached to dldo1 and the panel with reset w/o any supply regulators.
