Hi Shawn, On Tue, 13 Nov 2018 at 15:42, Shawn Guo <shawnguo@xxxxxxxxxx> wrote: > > On Mon, Nov 05, 2018 at 10:12:30AM +0100, Martin Kaiser wrote: > > Hi, > > > > Thus wrote Shawn Guo (shawnguo@xxxxxxxxxx): > > > > > On Thu, Nov 01, 2018 at 06:32:47PM +0100, Martin Kaiser wrote: > > > > The i.MX25 contains two EPIT (Enhanced Periodic Interrupt Timer) > > > > function blocks. Add their ipg and per clocks to the device tree. > > > > > > Signed-off-by: Martin Kaiser <martin@xxxxxxxxx> Acked-by: Clément Péron <peron.clem@xxxxxxxxx> > > > > > Are these EPIT devices actually used in upstream kernel, or just > > > somewhere else? > > > > Until I saw Vladimir's mail this morning, I wasn't aware of any mainline > > driver that's using the EPIT devices. I found that the clocks are > > missing when I tried to use EPIT with a company-internal driver that's > > not suitable for mainline integration. > > > > Still, I think that merging this patch does no harm. If the EPIT devices > > are present in the DT, we should add all resources they're using. > > Agreed. I will be happy to apply the patch if I can get an ACK from > Clément saying this works with his driver in upstreaming. I have paused the dev of this driver for now, but this is fine for me. Regards, Clement > > Shawn
