On Wed, 2014-03-12 at 09:50 +0100, Maxime COQUELIN wrote: > This patch replaces the raw values with ARRAY_SIZE for assigning the > ninput_delays and noutput_delays fields of STiH416's st_pctl_data struct. trivial note: > diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c [] > @@ -384,9 +384,9 @@ static unsigned int stih416_delays[] = {0, 300, 500, 750, 1000, 1250, 1500, > static const struct st_pctl_data stih416_data = { > .rt_style = st_retime_style_dedicated, > .input_delays = stih416_delays, > - .ninput_delays = 14, > + .ninput_delays = ARRAY_SIZE(stih416_delays), > .output_delays = stih416_delays, > - .noutput_delays = 14, > + .noutput_delays = ARRAY_SIZE(stih416_delays), > .alt = 0, .oe = 40, .pu = 50, .od = 60, .rt = 100, > }; > drivers/pinctrl/pinctrl-st.c- unsigned int *input_delays; drivers/pinctrl/pinctrl-st.c- unsigned int *output_delays; It may be better to change these to const unsigned int * and change static unsigned int stih416_delays[] = { to static const -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html