On Sun, Nov 11, 2018 at 1:03 PM Pavel Machek <pavel@xxxxxx> wrote: > > -"devicename:colour:function" > > +"colour:function" > > I don't think we want to do it in all cases. > > So, on my cellphone seeing lp5523:green:led is indeed not useful. > > But on notebook with usb keyboard attached, you need to keep the > devicename to be able to distinguish capslock on internal keyboard and > capslock on first USB keyboard and capslock on second USB keyboard. I agree with Pavel. I ran into this when connecting two identical keyboards to the same machine. The driver worked fine up until it tries to create two sysfs entries with the same name for capslock. BOOM! In this case I suggest "serialnumber:color:capslock" and similar. The important point is the string must be unique for each plugged device. Yours, Linus Walleij
