On Fri, 9 Nov 2018 17:40:55 +0200 Stefan Popa <stefan.popa@xxxxxxxxxx> wrote: > There are several ADC drivers that depend on the same device tree > bindings. Rather than continue to duplicate the properties, this patch > adds a common adc binding document that can be referenced. For beginning, > only two properties are documented. > > Signed-off-by: Stefan Popa <stefan.popa@xxxxxxxxxx> Hi Stefan, Looks good to me. Given the 'generic' nature of this one though I would like to leave some time for Rob and other devicetree specialists to sanity check it. Thanks, Jonathan > --- > Changes in v2, v3: > - N/A. > Changes in v4: > - Added this commit. > > Documentation/devicetree/bindings/iio/adc/adc.txt | 25 +++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/adc.txt > > diff --git a/Documentation/devicetree/bindings/iio/adc/adc.txt b/Documentation/devicetree/bindings/iio/adc/adc.txt > new file mode 100644 > index 0000000..1e3cc21 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/adc.txt > @@ -0,0 +1,25 @@ > +Common ADCs properties > + > +This binding is a work-in-progress > + > +Optional properties for child nodes: > +- bipolar : Boolean, if set the channel is used in bipolar mode. > +- diff-channels : Differential channels muxed for this ADC. The first value > + specifies the positive input pin, the second value the negative > + input pin. > + > +Example: > + adc@0 { > + compatible = "some,adc"; > + ... > + channel@0 { > + bipolar; > + diff-channels = <0 1>; > + ... > + }; > + > + channel@1 { > + diff-channels = <2 3>; > + ... > + }; > + };