On Fri, Nov 09, 2018 at 10:38:19AM +0530, Vinod Koul wrote:
> On 08-11-18, 15:04, Shawn Guo wrote:
> > From: Sriharsha Allenki <sallenki@xxxxxxxxxxxxxx>
> >
> > It adds bindings for Synopsys 28nm femto phy controller that supports
> > LS/FS/HS usb connectivity on Qualcomm chipsets.
> >
> > Signed-off-by: Sriharsha Allenki <sallenki@xxxxxxxxxxxxxx>
> > Signed-off-by: Anu Ramanathan <anur@xxxxxxxxxxxxxx>
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> > Signed-off-by: Shawn Guo <shawn.guo@xxxxxxxxxx>
> > ---
> > .../phy/qcom,snps-28nm-usb-hs-phy.txt | 101 ++++++++++++++++++
> > 1 file changed, 101 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/phy/qcom,snps-28nm-usb-hs-phy.txt
> >
> > diff --git a/Documentation/devicetree/bindings/phy/qcom,snps-28nm-usb-hs-phy.txt b/Documentation/devicetree/bindings/phy/qcom,snps-28nm-usb-hs-phy.txt
> > new file mode 100644
> > index 000000000000..75e7a09dd558
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/phy/qcom,snps-28nm-usb-hs-phy.txt
> > @@ -0,0 +1,101 @@
> > +Qualcomm Synopsys 28nm Femto phy controller
> > +===========================================
> > +
> > +Synopsys 28nm femto phy controller supports LS/FS/HS usb connectivity on
> > +Qualcomm chipsets.
> > +
> > +Required properties:
> > +
> > +- compatible:
> > + Value type: <string>
> > + Definition: Should contain "qcom,usb-snps-hsphy".
> > +
> > +- reg:
> > + Value type: <prop-encoded-array>
> > + Definition: USB PHY base address and length of the register map.
> > +
> > +- #phy-cells:
> > + Value type: <u32>
> > + Definition: Should be 0.
>
> I dont quite understand the definition that it should be 0, maybe you
> mean allowed value is 0, if so why have this property?
The property is defined by generic phy bindings phy/phy-bindings.txt.
I can add a pointer to it if you think that's necessary. The property
should be 0 for our device, because there is zero number cell in phy
specifier from dwc3 node as shown in the example.
dwc3@78c0000 {
...
phys = <&usb2_phy_prim>;
phy-names = "usb2-phy";
}
And for that reason, we can use the generic .of_xlate implementation
of_phy_simple_xlate() provided by phy core. There are some comments
in kernel doc of of_phy_simple_xlate() which might be helpful.
Shawn
