Dan, On 11/08/2018 07:00 PM, Dan Murphy wrote: > Jacek > > On 11/06/2018 04:07 PM, Jacek Anaszewski wrote: >> Introduce dedicated properties for conveying information about >> LED function and color. Mark old "label" property as deprecated. >> >> Signed-off-by: Jacek Anaszewski <jacek.anaszewski@xxxxxxxxx> >> Cc: Baolin Wang <baolin.wang@xxxxxxxxxx> >> Cc: Daniel Mack <daniel@xxxxxxxxxx> >> Cc: Dan Murphy <dmurphy@xxxxxx> >> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx> >> Cc: Oleh Kravchenko <oleg@xxxxxxxxxx> >> Cc: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> >> Cc: Simon Shields <simon@xxxxxxxxxxxxx> >> Cc: Xiaotong Lu <xiaotong.lu@xxxxxxxxxxxxxx> >> --- >> Documentation/devicetree/bindings/leds/common.txt | 52 +++++++++++++++++++---- >> 1 file changed, 44 insertions(+), 8 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/leds/common.txt b/Documentation/devicetree/bindings/leds/common.txt >> index aa13998..3efc826 100644 >> --- a/Documentation/devicetree/bindings/leds/common.txt >> +++ b/Documentation/devicetree/bindings/leds/common.txt >> @@ -10,14 +10,20 @@ can influence the way of the LED device initialization, the LED components >> have to be tightly coupled with the LED device binding. They are represented >> by child nodes of the parent LED device binding. >> >> + >> Optional properties for child nodes: >> - led-sources : List of device current outputs the LED is connected to. The >> outputs are identified by the numbers that must be defined >> in the LED device binding documentation. >> +- function: LED functon. Use one of the LED_FUNCTION_* prefixed definitions >> + from the header include/dt-bindings/leds/functions.h. >> + If there is no matching LED_FUNCTION available, add a new one. >> +- color : Color of the LED. > > Should we define the colors too? There are only really 4. Red, green, blue and white. > > Generally varying colors are created base on the primary colors. Even the amber color No problem, I can add LED colors. However, I don't quite follow how the mix of base color strings would give "amber" ? :-) -- Best regards, Jacek Anaszewski
