Hi Geert, Thank you for your feedback! > Subject: Re: [PATCH 3/4] ARM: dts: r8a77470: Add QSPI support > > Hi Fabrizio, > > On Thu, Nov 8, 2018 at 11:31 AM Fabrizio Castro > <fabrizio.castro@xxxxxxxxxxxxxx> wrote: > > > On Thu, Nov 8, 2018 at 11:22 AM Fabrizio Castro > > > <fabrizio.castro@xxxxxxxxxxxxxx> wrote: > > > > > From: Simon Horman <horms@xxxxxxxxxxxx> > > > > > Sent: 02 November 2018 11:50 > > > > > Subject: Re: [PATCH 3/4] ARM: dts: r8a77470: Add QSPI support > > > > > > > > > > On Thu, Nov 01, 2018 at 12:35:04PM +0000, Fabrizio Castro wrote: > > > > > > Add QSPI[01] support to the RZ/G1C SoC specific device tree. > > > > > > > > > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx> > > > > > > --- > > > > > > arch/arm/boot/dts/r8a77470.dtsi | 34 ++++++++++++++++++++++++++++++++++ > > > > > > 1 file changed, 34 insertions(+) > > > > > > > > > > > > diff --git a/arch/arm/boot/dts/r8a77470.dtsi b/arch/arm/boot/dts/r8a77470.dtsi > > > > > > index e6407e5..04a8877 100644 > > > > > > --- a/arch/arm/boot/dts/r8a77470.dtsi > > > > > > +++ b/arch/arm/boot/dts/r8a77470.dtsi > > > > > > @@ -20,6 +20,8 @@ > > > > > > i2c2 = &i2c2; > > > > > > i2c3 = &i2c3; > > > > > > i2c4 = &i2c4; > > > > > > +spi0 = &qspi0; > > > > > > +spi1 = &qspi1; > > > > > > }; > > > > > > > > > > Geert can comment but I believe we are moving away from using aliases > > > > > in this way and that it would be best if the above hunk was dropped > > > > > from this patch. > > > > > > > > > > https://patchwork.kernel.org/patch/10644159/ > > > > > > > > Geert, what do you want me to do here? > > > > > > Please drop the aliases. Thanks! > > > > Will do, will send a new version without the additional aliases. > > Thanks! > > > My understanding is that your personal preference is to only leave debug console and ethernet, > > Labeled serial ports and primary Ethernet, so U-Boot knows which MAC address > property to update. > > > shall I also get rid of what was already upstreamed for RZ/G related boards that is not in line > > with the new policy? > > I believe these are all serial ports, using aliases that match the documented > and/or labeled port names? So they don't have to be removed. We have also been using aliases for i2c, spi (like in this case), vin, etc., for all of the RZ/G boards, shall I get rid of those? Cheers, Fab > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
