On Tue, Nov 06, 2018 at 11:35:13AM +0100, Geert Uytterhoeven wrote: > Hi Marek, > > On Tue, Nov 6, 2018 at 11:32 AM Marek Vasut <marek.vasut@xxxxxxxxx> wrote: > > On 11/06/2018 06:26 AM, Yoshihiro Shimoda wrote: > > >> From: Marek Vasut, Sent: Tuesday, November 6, 2018 6:41 AM > > >> > > >> From: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx> > > >> > > >> This patch adds SDHI{0,1,3} device nodes for the r8a77990 SoC. > > >> > > >> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx> > > >> Signed-off-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxx> > > >> Cc: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > >> Cc: Simon Horman <horms+renesas@xxxxxxxxxxxx> > > >> Cc: Wolfram Sang <wsa@xxxxxxxxxxxxx> > > >> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> > > >> Cc: linux-renesas-soc@xxxxxxxxxxxxxxx > > >> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > > >> --- > > > > > > Thank you for the patch! > > > > > > Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> > > > > > > I guess this patch and the 2/2 patch for ebisu have to be merged into a patch though. > > > > I wonder about that, 1/2 is adding SDHI DT nodes for an SoC, 2/2 is > > enabling SDHI on a particular board, which I think should be separate. > > The arm-soc maintainers tend to disagree, that's why Shimoda-san asked > to combine them. That is also my understanding. Please consider combining these patches.