On 11/06/2018 06:29 AM, Yoshihiro Shimoda wrote:
> Hello Marek-san,
Hello Shimoda-san,
>> From: Marek Vasut, Sent: Tuesday, November 6, 2018 6:41 AM
>>
>> From: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx>
>>
>> This patch enables SD card slot connected to SDHI0, micro SD card slot
>> connected to SDHI1 and eMMC connected to SDHI3 on the Ebisu board using
>> the R8A77990 SoC.
>>
>> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx>
>> Signed-off-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxx>
>> Cc: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>> Cc: Simon Horman <horms+renesas@xxxxxxxxxxxx>
>> Cc: Wolfram Sang <wsa@xxxxxxxxxxxxx>
>> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
>> Cc: linux-renesas-soc@xxxxxxxxxxxxxxx
>> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
>> ---
>
> Thank you for the patch!
>
> Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
>
> I have a few nit comments below.
>
>> .../arm64/boot/dts/renesas/r8a77990-ebisu.dts | 136 ++++++++++++++++++
>> 1 file changed, 136 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
>> index 611f0265fcc5..bda1765dcdbd 100644
>> --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
>> +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> <snip>
>> + sdhi3_pins: sd3 {
>> + groups = "sdhi3_data8", "sdhi3_ctrl";
>> + function = "sdhi3";
>> + power-source = <1800>;
>> + };
>> +
>> + sdhi3_pins_uhs: sd3_uhs {
>> + groups = "sdhi3_data8", "sdhi3_ctrl";
>> + function = "sdhi3";
>> + power-source = <1800>;
>> + };
>
> I assumed that we will add "sdhi3_ds" into these groups when we add support for HS400 mode.
That's a good point, I think we can add it right away, so added in V2.
--
Best regards,
Marek Vasut
