Hi Jacopo,
On Mon, Nov 5, 2018 at 1:46 PM jacopo mondi <jacopo@xxxxxxxxxx> wrote:
> On Mon, Nov 05, 2018 at 01:07:58PM +0100, Geert Uytterhoeven wrote:
> > On Mon, Nov 5, 2018 at 12:49 PM Jacopo Mondi <jacopo+renesas@xxxxxxxxxx> wrote:
> > > The VIN driver bindings dictates fixed numbering for VIN endpoints connected
> > > to CSI-2 endpoints, even when a single endpoint exists.
> > >
> > > Without proper endpoint numbering the VIN driver fails to probe.
> > >
> > > Fixes: ec70407ae7d7 ("arm64: dts: renesas: r8a77990: Add VIN and CSI-2 device nodes")
> > > Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@xxxxxxxxxxx>
> >
> > Was this patch authored by you or by Matsuoka-san?
>
> The original patch didn't apply
>
> $git am index.html\?id\=1b1b73f7558d867d72e198901b84bec1e6ef1405
> Applying: arm64: dts: r8a77990: Fix csi2 endpoint number in VIN node
> error: patch failed: arch/arm64/boot/dts/renesas/r8a77990.dtsi:811
> error: arch/arm64/boot/dts/renesas/r8a77990.dtsi: patch does not apply
Right, the BSP had the unit address and reg property, while upstream hadn't.
So don't you need to re-add:
#address-cells = <1>;
#size-cells = <0>;
else dtc complains:
arch/arm64/boot/dts/renesas/r8a77990-ebisu.dtb: Warning
(reg_format): /soc/video@e6ef4000/ports/port@1/endpoint@2:reg:
property has invalid length (4 bytes) (#address-cells == 2,
#size-cells == 1)
arch/arm64/boot/dts/renesas/r8a77990-ebisu.dtb: Warning
(pci_device_bus_num): Failed prerequisite 'reg_format'
arch/arm64/boot/dts/renesas/r8a77990-ebisu.dtb: Warning
(simple_bus_reg): Failed prerequisite 'reg_format'
arch/arm64/boot/dts/renesas/r8a77990-ebisu.dtb: Warning
(i2c_bus_reg): Failed prerequisite 'reg_format'
arch/arm64/boot/dts/renesas/r8a77990-ebisu.dtb: Warning
(spi_bus_reg): Failed prerequisite 'reg_format'
arch/arm64/boot/dts/renesas/r8a77990-ebisu.dtb: Warning
(avoid_default_addr_size):
/soc/video@e6ef4000/ports/port@1/endpoint@2: Relying on default
#address-cells value
arch/arm64/boot/dts/renesas/r8a77990-ebisu.dtb: Warning
(avoid_default_addr_size):
/soc/video@e6ef4000/ports/port@1/endpoint@2: Relying on default
#size-cells value
arch/arm64/boot/dts/renesas/r8a77990-ebisu.dtb: Warning
(graph_endpoint): /soc/video@e6ef4000/ports/port@1/endpoint@2: graph
node '#address-cells' is -1, must be 1
arch/arm64/boot/dts/renesas/r8a77990-ebisu.dtb: Warning
(graph_endpoint): /soc/video@e6ef4000/ports/port@1/endpoint@2: graph
node '#size-cells' is -1, must be 0
> So I made a new one, changing the commit message and adding the Fixes
> tag.
>
> I can change author if you want to.
In such a case, I usually add "based on a patch in the BSP by ...", instead of
the original SoB-chain.
> > > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx>
> > > Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
