Hi Faiz, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] [also build test ERROR on v4.19 next-20181102] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Faiz-Abbas/Add-Support-for-MCAN-transceivers-in-AM65x-evm/20181103-103548 config: sh-allmodconfig (attached as .config) compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.2.0 make.cross ARCH=sh All error/warnings (new ones prefixed by >>): In file included from drivers//phy/phy-of-simple.c:10:0: >> drivers//phy/phy-of-simple.c:76:25: error: 'phy_simple_phy_dt_ids' undeclared here (not in a function); did you mean 'phy_simple_dt_ids'? MODULE_DEVICE_TABLE(of, phy_simple_phy_dt_ids); ^ include/linux/module.h:213:15: note: in definition of macro 'MODULE_DEVICE_TABLE' extern typeof(name) __mod_##type##__##name##_device_table \ ^~~~ >> include/linux/module.h:213:21: error: '__mod_of__phy_simple_phy_dt_ids_device_table' aliased to undefined symbol 'phy_simple_phy_dt_ids' extern typeof(name) __mod_##type##__##name##_device_table \ ^ >> drivers//phy/phy-of-simple.c:76:1: note: in expansion of macro 'MODULE_DEVICE_TABLE' MODULE_DEVICE_TABLE(of, phy_simple_phy_dt_ids); ^~~~~~~~~~~~~~~~~~~ -- In file included from drivers/phy/phy-of-simple.c:10:0: drivers/phy/phy-of-simple.c:76:25: error: 'phy_simple_phy_dt_ids' undeclared here (not in a function); did you mean 'phy_simple_dt_ids'? MODULE_DEVICE_TABLE(of, phy_simple_phy_dt_ids); ^ include/linux/module.h:213:15: note: in definition of macro 'MODULE_DEVICE_TABLE' extern typeof(name) __mod_##type##__##name##_device_table \ ^~~~ >> include/linux/module.h:213:21: error: '__mod_of__phy_simple_phy_dt_ids_device_table' aliased to undefined symbol 'phy_simple_phy_dt_ids' extern typeof(name) __mod_##type##__##name##_device_table \ ^ drivers/phy/phy-of-simple.c:76:1: note: in expansion of macro 'MODULE_DEVICE_TABLE' MODULE_DEVICE_TABLE(of, phy_simple_phy_dt_ids); ^~~~~~~~~~~~~~~~~~~ vim +76 drivers//phy/phy-of-simple.c > 10 #include <linux/module.h> 11 #include <linux/regulator/consumer.h> 12 13 static int phy_simple_power_on(struct phy *phy) 14 { 15 if (phy->pwr) 16 return regulator_enable(phy->pwr); 17 18 return 0; 19 } 20 21 static int phy_simple_power_off(struct phy *phy) 22 { 23 if (phy->pwr) 24 return regulator_disable(phy->pwr); 25 26 return 0; 27 } 28 29 static const struct phy_ops phy_simple_ops = { 30 .power_on = phy_simple_power_on, 31 .power_off = phy_simple_power_off, 32 .owner = THIS_MODULE, 33 }; 34 35 int phy_simple_probe(struct platform_device *pdev) 36 { 37 struct phy_provider *phy_provider; 38 struct device *dev = &pdev->dev; 39 struct regulator *pwr = NULL; 40 struct phy *phy; 41 u32 bus_width = 0; 42 u32 max_bitrate = 0; 43 int ret; 44 45 phy = devm_phy_create(dev, dev->of_node, 46 &phy_simple_ops); 47 48 if (IS_ERR(phy)) { 49 dev_err(dev, "Failed to create phy\n"); 50 return PTR_ERR(phy); 51 } 52 53 device_property_read_u32(dev, "bus-width", &bus_width); 54 phy->attrs.bus_width = bus_width; 55 device_property_read_u32(dev, "max-bitrate", &max_bitrate); 56 phy->attrs.max_bitrate = max_bitrate; 57 58 pwr = devm_regulator_get_optional(dev, "pwr"); 59 if (IS_ERR(pwr)) { 60 ret = PTR_ERR(pwr); 61 dev_err(dev, "Couldn't get regulator. ret=%d\n", ret); 62 return ret; 63 } 64 phy->pwr = pwr; 65 66 phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate); 67 68 return PTR_ERR_OR_ZERO(phy_provider); 69 } 70 71 static const struct of_device_id phy_simple_dt_ids[] = { 72 { .compatible = "simple-phy"}, 73 {} 74 }; 75 > 76 MODULE_DEVICE_TABLE(of, phy_simple_phy_dt_ids); 77 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
