> -----Original Message----- > From: Fabio Estevam [mailto:festevam@xxxxxxxxx] > Sent: Thursday, November 1, 2018 6:36 PM [...] > > On Thu, Nov 1, 2018 at 7:28 AM Fabio Estevam <festevam@xxxxxxxxx> > wrote: > > > > Hi Dong, > > > > On Wed, Oct 31, 2018 at 11:46 AM A.s. Dong <aisheng.dong@xxxxxxx> > wrote: > > > > > + reg_vsd_3v3: regulator-vsd-3v3 { > > > + compatible = "regulator-fixed"; > > > + regulator-name = "VSD_3V3"; > > > + regulator-min-microvolt = <3300000>; > > > + regulator-max-microvolt = <3300000>; > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&pinctrl_usdhc0_rst>; > > > + gpio = <&gpio_ptd 0 GPIO_ACTIVE_HIGH>; > > > + enable-active-high; > > > > You model this as a regulator... > > > > > +&usdhc0 { > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&pinctrl_usdhc0>; > > > + cd-gpios = <&gpio_ptc 10 GPIO_ACTIVE_LOW>; > > > + vmmc-supply = <®_vsd_3v3>; > > > > but as this pins controls the reset of the SD port it seems that using > > mmc-pwrseq would be more appropriate. > > > > This way you could pass 'reset-gpios' inside the pwrseq node, which > > would describe the hardware more accurately. > > Just looked at the schematics and the SD0_nRST signals is only used when the > eMMC is populated. > > As you are only defining SD0_DATA0-DATA3 it means you are using the > microSD option (option 1 as per the schematics). > > In the microSD option the SD0_nRST is not used, so better not to describe it in > device tree. Can you tell which version were you looking at? >From my version SPF-29163_A1, it's populated by default. Regards Dong Aisheng
