Re: [PATCH] ARM: dts: fsl: Fix improperly quoted stdout-path values

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 30.10.2018 20:08, Rob Herring wrote:
> A quoted label reference doesn't expand to the node path and is taken as
> a literal string. Dropping the quotes can fix this unless the baudrate
> string is appended in which case we have to use the alias.
> 
> At least on VF610, the problem was masked by setting the console in
> bootargs. Use the alias syntax with baudrate parameter so we can drop
> setting the console in bootargs.
> 
> Cc: Shawn Guo <shawnguo@xxxxxxxxxx>
> Cc: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> Cc: Pengutronix Kernel Team <kernel@xxxxxxxxxxxxxx>
> Cc: Fabio Estevam <fabio.estevam@xxxxxxx>
> Cc: NXP Linux Team <linux-imx@xxxxxxx>
> Cc: Mark Rutland <mark.rutland@xxxxxxx>
> Cc: Stefan Agner <stefan@xxxxxxxx>
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>

Reviewed-by: Stefan Agner <stefan@xxxxxxxx>

--
Stefan

> ---
>  arch/arm/boot/dts/imx53-ppd.dts       | 2 +-
>  arch/arm/boot/dts/vf610m4-colibri.dts | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx53-ppd.dts b/arch/arm/boot/dts/imx53-ppd.dts
> index cdb90bee7b4a..f202396e3f2a 100644
> --- a/arch/arm/boot/dts/imx53-ppd.dts
> +++ b/arch/arm/boot/dts/imx53-ppd.dts
> @@ -55,7 +55,7 @@
>  	};
>  
>  	chosen {
> -		stdout-path = "&uart1:115200n8";
> +		stdout-path = "serial0:115200n8";
>  	};
>  
>  	memory@70000000 {
> diff --git a/arch/arm/boot/dts/vf610m4-colibri.dts
> b/arch/arm/boot/dts/vf610m4-colibri.dts
> index 41ec66a96990..1a7356b841d2 100644
> --- a/arch/arm/boot/dts/vf610m4-colibri.dts
> +++ b/arch/arm/boot/dts/vf610m4-colibri.dts
> @@ -50,8 +50,8 @@
>  	compatible = "fsl,vf610m4";
>  
>  	chosen {
> -		bootargs = "console=ttyLP2,115200 clk_ignore_unused init=/linuxrc rw";
> -		stdout-path = "&uart2";
> +		bootargs = "clk_ignore_unused init=/linuxrc rw";
> +		stdout-path = "serial2:115200;
>  	};
>  
>  	memory@8c000000 {



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux