Re: [PATCH V3 2/2] csky: use common dtb build rules

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 30, 2018 at 2:10 PM Rob Herring <robh@xxxxxxxxxx> wrote:
>
> On Tue, Oct 30, 2018 at 12:50 PM Guo Ren <ren_guo@xxxxxxxxx> wrote:
> >
> > Remove the Kbuild rules in arch/csky and use common dtb build rules.
> >
> > This modification is based on:
> >
> > commit 37c8a5fafa3b ("kbuild: consolidate Devicetree dtb build rules")
> >
> > Signed-off-by: Guo Ren <ren_guo@xxxxxxxxx>
> > Cc: Rob Herring <robh@xxxxxxxxxx>
> > Cc: Arnd Bergmann <arnd@xxxxxxxx>
> > ---
> >  arch/csky/Makefile          | 11 +----------
> >  arch/csky/boot/dts/Makefile |  3 ---
> >  2 files changed, 1 insertion(+), 13 deletions(-)
>
> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>

BTW, it's not very not clear what the change from v2 was. In the
future, please include a change log in each patch. Also, Arnd acked
v2, so you should add those when posting a new version unless there's
major changes, but don't post new versions just to add the
acks/reviewed-bys. It doesn't really matter in this case as you are
the maintainer and have to collect them, but generally the maintainers
only collect acks on the version they apply and don't go looking at
prior versions.

Rob



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux