All On 10/26/2018 03:37 AM, Pavel Machek wrote: > Hi! > >>> Do you have an opinion on this? >> >> This is this problem with the Device Tree's scope of responsibility. >> It is defined as a means for "describing the hardware", but often >> this rule is abused by the properties that fall into "configuration" >> category. E.g. default-state, retain-state-suspended from leds-gpio.txt >> or linux-default-trigger from common LED bindings. > > "retain-state-suspended" is actually hardware property. On PCs, > (most?) LEDs will go off in suspend. On android phones, LEDs stay on > while suspended. > > "linux-default-trigger" is actually kind-of hardware property, too. If > LED has an icon near it (or on it), you want to use that LED in that > meaning. > > (Thinkpad X60 has "wifi", "bluetooth", "numlock", "capslock", "hdd", > "power", "battery", "ac" and "sleep" leds. Surely we should use them > in that meaning?) > > Now, if someone has leds labeled "user 1..user 4" and uses > "linux-default-trigger" there, that is kind of "more interesting". > > "default-state" is similar (subset of "linux-default-trigger"); you > don't want power LED to go off during kernel boot... I just want to follow up here and let you know that I have not abandoned this. I am trying to rework and fix up the ti lmu binding as asked by Pavel. Its proving to be a bit of a challenge based on looking forward to what will be the implementation. I also did go offline and speak with Tony. I have a Droid 4 so I can test all of this on production hardware as well. Updated patchset will take some time to get out. Dan > > Pavel > -- ------------------ Dan Murphy
