Hi Rob,
Thanks for the review,
On 2018-10-25 20:28, Rob Herring wrote:
On Wed, Oct 24, 2018 at 04:44:37PM +0530, anilc@xxxxxxxxxxxxxx wrote:
Hi,
Thanks for the comments, response inline.
FYI, this was from a bot.
I have realized after I sent the mail.
Thanks,
AnilKumar
On 2018-10-18 17:13, kbuild test robot wrote:
> Hi AnilKumar,
>
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on cryptodev/master]
> [also build test ERROR on v4.19-rc8 next-20181018]
> [if your patch is applied to the wrong git tree, please drop us a note
> to help improve the system]
>
> url:
> https://github.com/0day-ci/linux/commits/AnilKumar-Chimata/firmware-qcom-scm-Update-qcom_scm_call-signature/20181018-182318
> base:
> https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git
> master
> config: sh-allmodconfig (attached as .config)
> compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
> reproduce:
> wget
> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
> -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # save the attached .config to linux build tree
> GCC_VERSION=7.2.0 make.cross ARCH=sh
>
> All errors (new ones prefixed by >>):
>
> > > drivers/crypto/qce/ice.c:1372:5: error: redefinition of
> > > 'qcom_ice_setup_ice_hw'
> int qcom_ice_setup_ice_hw(const char *storage_type, int enable)
> ^~~~~~~~~~~~~~~~~~~~~
> In file included from drivers/crypto/qce/ice.c:25:0:
> include/crypto/ice.h:60:19: note: previous definition of
> 'qcom_ice_setup_ice_hw' was here
> static inline int qcom_ice_setup_ice_hw(const char *storage_type,
> int enable)
> ^~~~~~~~~~~~~~~~~~~~~
>
> vim +/qcom_ice_setup_ice_hw +1372 drivers/crypto/qce/ice.c
>
> 1371
> > 1372 int qcom_ice_setup_ice_hw(const char *storage_type, int enable)
> 1373 {
> 1374 struct ice_device *ice_dev = NULL;
> 1375 int ret = -1;
> 1376
> 1377 ice_dev = get_ice_device_from_storage_type(storage_type);
> 1378 if (ice_dev == ERR_PTR(-EPROBE_DEFER))
> 1379 return -EPROBE_DEFER;
> 1380
> 1381 if (!ice_dev)
> 1382 return ret;
> 1383
> 1384 if (enable)
> 1385 return enable_ice_setup(ice_dev);
> 1386
> 1387 return disable_ice_setup(ice_dev);
> 1388 }
> 1389
We will check and get back on the compilation. What is the idea behind
for
this
effort, is this for testing the ICE driver?
The purpose is to make sure changes don't break builds that you likely
haven't tested. Either different architectures or configurations.
Got the point, will try to avoid this in future.
Rob
