Hi Sibi, On 10/26/2018 03:25 PM, Sibi Sankar wrote: > Add SCM DT node to enable SCM functionality on SDM845. > > Signed-off-by: Sibi Sankar <sibis@xxxxxxxxxxxxxx> > --- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi > index b72bdb0a31a5..fad22acfda4d 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi > @@ -221,6 +221,12 @@ > }; > }; > > + firmware { > + scm { > + compatible = "qcom,scm-sdm845", "qcom,scm"; > + }; > + }; What will happen if the platform is without tz firmware? I'd move this DT node in sdm845-mtp.dts or at least make it status = disabled. -- regards, Stan