Hi Johan, >> This adds the UART phy interface for the pn533 driver. >> The pn533 driver can be used through UART interface this way. >> It is implemented as a serdev device. > > Just a few drive-by comments below. > >> +// SPDX-License-Identifier: GPL-2.0 > > This should match MODULE_LICENSE below which currently says v2 *or > later*. > >> +/* >> + * Driver for NXP PN532 NFC Chip - UART transport layer >> + * >> + * Copyright (C) 2018 Lemonage Software GmbH >> + * Author: Lars Pöschel <poeschel@xxxxxxxxxxx> >> + * All rights reserved. >> + */ > >> +#define VERSION "0.1" > > We don't version kernel drivers individually, so please drop this here > and below. if we don’t then maybe send patches to remove MODULE_VERSION first. Otherwise this is totally fine to do. There are currently 670 usages of MODULE_VERSION and I have not heard anybody looking at removing this. Regards Marcel
