Hi Jiada, On Thu, Oct 25, 2018 at 9:24 AM <jiada_wang@xxxxxxxxxx> wrote: > From: Jiada Wang <jiada_wang@xxxxxxxxxx> > > Add avb counter clock node to R-Car ULCB boards > > Signed-off-by: Jiada Wang <jiada_wang@xxxxxxxxxx> Thanks for your patch! > --- a/arch/arm64/boot/dts/renesas/ulcb.dtsi > +++ b/arch/arm64/boot/dts/renesas/ulcb.dtsi > @@ -32,6 +32,12 @@ > clock-frequency = <12288000>; > }; > > + clk_avb: avb-clock@ec5a011c { > + compatible = "renesas,clk-avb"; > + reg = <0 0xec5a011c 0 0x24>; > + #clock-cells = <1>; > + }; > + > hdmi0-out { > compatible = "hdmi-connector"; > type = "a"; Why would this belong in the board .dtsi, not in the SoC .dtsi? (same for salvator-common.dtsi) How is this intended to be used by the AVB? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds