Hi Sven, thanks for your patch! On Wed, Oct 24, 2018 at 4:25 PM Sven Van Asbroeck <svendev@xxxxxxxx> wrote: > + - pwms : the pwm connected to the bridge's 'pwm input'. That is really unintuitive and needs a detailed explanation. What is a bridge doing with a PWM? Is it 100% certain this is a PWM, it's not just a .... clock? A pwm is a pule WIDTH modulator and I can't for my life understand why a bus bridge needs a signal with variable pulse width, but surprise me! :D > + fsl,weim-cs-timing = <0x024400b1 0x00001010 0x20081100 > + 0x00000000 0xa0000240 0x00000000>; Is it just a copy/paste from Documentation/devicetree/bindings/bus/imx-weim.txt leftover? It was mentioned as undocumented but it is also pretty terse with these opaque hex numbers. I would never let the Freescale binding pass if I was reviewing it. Look at my bindings for Qualcomm EBI in Documentation/devicetree/bindings/bus/qcom,ebi2.txt for example. But maybe it's not even supposed to be there. Yours, Linus Walleij
