-----Original Message----- From: Fabio Estevam [mailto:festevam@xxxxxxxxx] Sent: 2018年10月24日 19:20 To: Joakim Zhang <qiangqing.zhang@xxxxxxx> Cc: Shawn Guo <shawnguo@xxxxxxxxxx>; Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>; Sascha Hauer <kernel@xxxxxxxxxxxxxx>; Fabio Estevam <fabio.estevam@xxxxxxx>; dl-linux-imx <linux-imx@xxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>; open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS <devicetree@xxxxxxxxxxxxxxx>; linux-kernel <linux-kernel@xxxxxxxxxxxxxxx>; A.s. Dong <aisheng.dong@xxxxxxx> Subject: Re: [PATCH V1 3/3] ARM: dts: sabreauto: Add flexcan support Hi Joakim, On Wed, Oct 24, 2018 at 8:15 AM Joakim Zhang <qiangqing.zhang@xxxxxxx> wrote: > diff --git a/arch/arm/boot/dts/imx6dl-sabreauto-flexcan1.dts b/arch/arm/boot/dts/imx6dl-sabreauto-flexcan1.dts > new file mode 100644 > index 000000000000..963e0b559d60 > --- /dev/null > +++ b/arch/arm/boot/dts/imx6dl-sabreauto-flexcan1.dts > @@ -0,0 +1,19 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) 2013 Freescale Semiconductor, Inc. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. You can remove this paragraph as you are using SPDX tag. > +++ b/arch/arm/boot/dts/imx6q-sabreauto-flexcan1.dts > @@ -0,0 +1,19 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) 2013 Freescale Semiconductor, Inc. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + */ Ditto. > +&can1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_flexcan1>; > + pinctrl-assert-gpios = <&max7310_b 3 GPIO_ACTIVE_HIGH>; /* TX */ This property does not exist in upstream. Hi Fabio, I will modify what you have commented. Thanks a lot. Best Regards, Joakim Zhang
