On Wed 2018-10-24 07:27:57, Dan Murphy wrote: > Pavel > > On 10/24/2018 04:14 AM, Pavel Machek wrote: > > On Tue 2018-10-23 12:06:17, Dan Murphy wrote: > >> From: Pavel Machek <pavel@xxxxxx> > >> > >> This adds backlight support for the following TI LMU > >> chips: LM3532, LM3631, LM3632, LM3633, LM3695 and LM3697. > >> > >> It controls LEDs on Droid 4 > >> smartphone, including keyboard and screen backlights. > >> > >> Signed-off-by: Milo Kim <milo.kim@xxxxxx> > >> [add LED subsystem support for keyboard backlight and rework DT > >> binding according to Rob Herrings feedback] > >> Signed-off-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxxxx> > >> [remove backlight subsystem support for now] > >> Signed-off-by: Pavel Machek <pavel@xxxxxx> > > > > This is not correct way to sign off a patch. > > > > What is worse, this is very different from patch I submitted; this > > misses imporant parts while my patch was complete. > > > > I already submitted better patch for both the driver and device tree > > bindings. Can we go back and apply that? > > > > Then you can add your changes on top of that, if they actually make > > the situation better. > > Thanks for this. I wanted to make sure not to loose any authorship or credit > in the commit. Actually removing Milo might help stop getting the bounce back > from the mail daemon. > > I was using the RFC patch as my base https://lore.kernel.org/patchwork/patch/978995/ > > Which contains this sign off. Yeah, but you need to append your sign-off to the end, preferably prepending note saying what you modified. [I'm ok with the original patch, but I'm not ok with your version]. From: Pavel Machek <pavel@xxxxxx> Is not correct. Original patch is from Milo, if you want to add explicit From:, I guess it should be his. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: Digital signature
