On Tue 2018-10-23 12:06:21, Dan Murphy wrote: > The LM3633 is a single function LED driver. The single function LED > driver needs to reside in the LED directory as a dedicated LED driver > and not as a MFD device. The device does have common brightness and ramp > features and those can be accomodated by a TI LMU framework. > > The LM3633 dt binding needs to be moved from the ti-lmu.txt and a dedicated > LED dt binding needs to be added. The new LM3633 LED dt binding will then > reside in the Documentation/devicetree/bindings/leds directory and follow the > current LED and general bindings guidelines. What? > .../devicetree/bindings/leds/leds-lm3633.txt | 102 ++++++++++++++++++ > .../devicetree/bindings/mfd/ti-lmu.txt | 48 --------- > 2 files changed, 102 insertions(+), 48 deletions(-) > create mode 100644 > Documentation/devicetree/bindings/leds/leds-lm3633.txt > index 920f910be4e9..573e88578d3d 100644 > --- a/Documentation/devicetree/bindings/mfd/ti-lmu.txt > +++ b/Documentation/devicetree/bindings/mfd/ti-lmu.txt > @@ -7,7 +7,6 @@ TI LMU driver supports lighting devices below. > LM3532 Backlight > LM3631 Backlight and regulator > LM3632 Backlight and regulator > - LM3633 Backlight, LED and fault monitor > LM3695 Backlight Are you seriously proposing to take one binding and split it into 6 copy&pasted ones? That's not the way we do development. NAK. We don't want to have copy & pasted code. We also don't want to have copy & pasted bindings. Nor changelogs, for that matter. Thank you, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: Digital signature
