On Fri, Oct 19, 2018 at 12:26:22PM +0100, Mark Brown wrote: > On Fri, Oct 19, 2018 at 10:50:02AM +0100, Charles Keepax wrote: > > Please do not submit new versions of already applied patches, please > submit incremental updates to the existing code. Modifying existing > commits creates problems for other users building on top of those > commits so it's best practice to only change pubished git commits if > absolutely essential. > I don't think any of this has been applied anywhere yet. > > +++ b/drivers/regulator/lochnagar-regulator.c > > @@ -0,0 +1,255 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Lochnagar regulator driver > > Please don't mix C and C++ comments like this in the same block, just > have it be a C++ block so it looks consistent. Can do. Thanks, Charles
