On Thu, Oct 18, 2018 at 05:00:28PM +0200, Marcel Holtmann wrote: > Hi Lars, > > > This adds the UART phy interface for the pn533 driver. > > The pn533 driver can be used through UART interface this way. > > It is implemented as a serdev device. > > > > Signed-off-by: Lars Poeschel <poeschel@xxxxxxxxxxx> > > --- > > Changes in v2: > > - switched from tty line discipline to serdev, resulting in many > > simplifications > > - SPDX License Identifier > > > > drivers/nfc/pn533/Kconfig | 10 ++ > > drivers/nfc/pn533/Makefile | 2 + > > drivers/nfc/pn533/pn533.h | 8 ++ > > drivers/nfc/pn533/uart.c | 283 +++++++++++++++++++++++++++++++++++++ > > 4 files changed, 303 insertions(+) > > create mode 100644 drivers/nfc/pn533/uart.c > > > > diff --git a/drivers/nfc/pn533/Kconfig b/drivers/nfc/pn533/Kconfig > > index d94122dd30e4..da3ea2dbaa8a 100644 > > --- a/drivers/nfc/pn533/Kconfig > > +++ b/drivers/nfc/pn533/Kconfig > > @@ -25,3 +25,13 @@ config NFC_PN533_I2C > > > > If you choose to build a module, it'll be called pn533_i2c. > > Say N if unsure. > > + > > +config NFC_PN532_UART > > + tristate "NFC PN532 device support (UART)” > > you are missing the "depends on SERIAL_DEV_BUS” here. Yes, absolutely right. I missed that. I will post a follow-up. BTW a question: Only enabling SERIAL_DEV_BUS did not suffice for me. I also had to enable SERIAL_DEV_CTRL_TTYPORT, otherwise the probe of the driver was not called. This seems a bit odd to me. This option seems unrelated, but without it, it did not work. Should I better depend on SERIAL_DEV_CTRL_TTYPORT then ? Thanks, Lars
