On Wed, Oct 17, 2018 at 07:24:40AM +0000, A.s. Dong wrote:
> As the power domain API might change in the future for new SoCs, although
> in a very low possibility, it's still better to make the compatible string
> more SoC specific to avoid the possible version change for new SoCs.
>
> Due to there're still no users in kernel, it's safe to update it without
> breaking anything.
>
> Cc: Shawn Guo <shawnguo@xxxxxxxxxx>
> Cc: Sascha Hauer <kernel@xxxxxxxxxxxxxx>
> Cc: Fabio Estevam <fabio.estevam@xxxxxxx>
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> Cc: Mark Rutland <mark.rutland@xxxxxxx>
> Cc: devicetree@xxxxxxxxxxxxxxx
> Suggested-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> Signed-off-by: Dong Aisheng <aisheng.dong@xxxxxxx>
checkpatch says:
WARNING: Missing Signed-off-by: line by nominal patch author 'A.s. Dong <aisheng.dong@xxxxxxx>'
> ---
> ChangeLog:
> v5->v6:
> * new patch
> ---
> Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> index 46d0af1..87fc4b4 100644
> --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> @@ -58,7 +58,7 @@ This binding for the SCU power domain providers uses the generic power
> domain binding[2].
>
> Required properties:
> -- compatible: Should be "fsl,scu-pd".
> +- compatible: Should be "fsl,imx8qxp-scu-pd".
You can keep both if you think future SoCs will be compatible.
> - #address-cells: Should be 1.
> - #size-cells: Should be 0.
>
> @@ -153,7 +153,7 @@ firmware {
> };
>
> imx8qx-pm {
> - compatible = "fsl,scu-pd";
> + compatible = "fsl,imx8qxp-scu-pd";
> #address-cells = <1>;
> #size-cells = <0>;
>
> --
> 2.7.4
>
