Hi Rob Thank you for your feedback > > From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> > > > > 74aup1g157gw needs i0 and i1 pin as input, select and output it by > > sel gpio pin. This patch adds description for 74aup1g157gw as clock > > multiplexer. > > "nxp,74aup1g157gw-clk" will select most closest input as output, > > "nxp,74aup1g157gw-audio-clk" will select 48kHz/44.1kHz categorized > > input as output. > > > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> > > --- > > .../devicetree/bindings/clock/nxp,74aup1g157gw.txt | 19 +++++++++++++++++++ > > 1 file changed, 19 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/clock/nxp,74aup1g157gw.txt > > > > diff --git a/Documentation/devicetree/bindings/clock/nxp,74aup1g157gw.txt b/Documentation/devicetree/bindings/clock/nxp,74aup1g157gw.txt > > new file mode 100644 > > index 0000000..d07bc04 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/clock/nxp,74aup1g157gw.txt > > @@ -0,0 +1,19 @@ > > +NXP 74AUP1G157GW Low-power 2-input multiplexer for clock > > + > > +Required properties: > > +- compatible: "nxp,74aup1g157gw-clk" (select closest input as output) > > + "nxp,74aup1g157gw-audio-clk (select 48kHz / 44.1kHz as output) > > I don't understand why you need the second one. > > > What's wrong with the existing gpio-mux-clock binding? Thanks. I already noticed that gpio-mux-clock is very OK to me (and I think I posted it to ML). Please drop this patch.