> >> + if (of_device_is_compatible(pdev->dev.of_node, > >> + "sirf,prima2-audio")) { > >> + cell = sirf_audio_prima2_devs; > >> + cell_number = ARRAY_SIZE(sirf_audio_prima2_devs); > > > > s/cell_number/n_devs > > > >> + } else if (of_device_is_compatible(pdev->dev.of_node, > >> + "sirf,atlas6-audio")) { > >> + cell = sirf_audio_atlas6_devs; > >> + cell_number = ARRAY_SIZE(sirf_audio_atlas6_devs); > > > > s/cell_number/n_devs > > > >> + } else > >> + return -EINVAL; > > > > I'm not sure there's any need for this. Why don't you just parse the > > child nodes? Are you even sure you need an MFD at all? It appears > > you're just using an MFD to share a regmap. Seems like over-kill to me. > > In my case, the prima2 and atlas6 codec have small different. But > they use the same register address space. > The sound codec driver need know what codec device is applied. Mark, I understand it was you who made the original request for the regmap to be shared between devices. Was it an MFD that you had in mind? -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html