On Wed, Mar 5, 2014 at 6:00 PM, Josh Cartwright <joshc@xxxxxxxxxxxxxx> wrote: > On Wed, Mar 05, 2014 at 12:58:55PM -0800, Stephen Boyd wrote: >> On 03/05/14 11:29, Josh Cartwright wrote: >> > diff --git a/Documentation/devicetree/bindings/rtc/qcom,pm8xxx-rtc.txt b/Documentation/devicetree/bindings/rtc/qcom,pm8xxx-rtc.txt >> > new file mode 100644 >> > index 0000000..699bd30 >> > --- /dev/null >> > +++ b/Documentation/devicetree/bindings/rtc/qcom,pm8xxx-rtc.txt >> > @@ -0,0 +1,29 @@ >> > +* Real-Time Clock for Qualcomm 8058/8921 PMICs >> > + >> > +Required properties: >> > +- compatible: should be one of the following. >> > + * "qcom,pm8058-rtc" >> > + * "qcom,pm8921-rtc" >> > +- reg: base address of the register region >> > +- reg-names: corresponding reg names for the regions listed in the 'reg' >> > + property, must contain: >> > + "rtc_base" - base of the RTC register region >> >> optional reg-names? >> >> > +- interrupts: interrupt list for the RTC, must contain a single interrupt >> > + specifier for the alarm interrupt >> > +- interrupt-names: corresponding interrupt names for the interrupts listed in >> > + the 'interrupts' property, must contain: >> > + "alarm" - summary interrupt for PMIC peripherals >> >> optional interrupt-names? > > It isn't clear to me why these should be made optional, I hope Rob > provides some clarification in the sdhci-msm thread. Because reg and interrupt names are relatively new and reluctantly added by DT maintainers. Personally, I think it was a mistake and it is simply Linux specific information leaking into the DT, but it did make transition to DT easier. The requirement is still the ordering of reg and interrupts fields must be defined and you cannot rely on the names to define the order. It is quite pointless here since you only have 1 field. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
