Hi Lucas,
On Tue, Oct 16, 2018 at 1:43 PM Lucas Stach <l.stach@xxxxxxxxxxxxxx> wrote:
> --- /dev/null
> +++ b/drivers/irqchip/irq-imx-irqsteer.c
> @@ -0,0 +1,281 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
According to Documentation/process/license-rules.rst this should be:
// SPDX-License-Identifier: GPL-2.0+
> + ret = clk_prepare_enable(data->ipg_clk);
> + if (ret) {
> + dev_err(&pdev->dev, "failed to enable ipg clk: %d\n", ret);
> + return ret;
> + }
> +
> + /* enable channel 1 by default */
> + writel_relaxed(1, data->regs + CHANCTRL);
> +
> + data->domain = irq_domain_add_linear(np, data->channum * 32,
> + &imx_irqsteer_domain_ops, data);
> + if (!data->domain) {
> + dev_err(&data->pdev->dev, "failed to create IRQ domain\n");
You should call clk_disable_unprepare(irqsteer_data->ipg_clk); prior
to returning.
> + return -ENOMEM;
