Hi Daniel, On Sun, Oct 14, 2018 at 10:38:36PM +0200, Daniel Lezcano wrote: > On 14/10/2018 18:26, Guo Ren wrote: > Thanks Guo, > > the descriptions look ok for the timer part. Can you resend the DT > bindings + timers patches separately with the commit log updated ? Ok, immediately. > > When you add the Changelog you have to insert it *after* the first > '---', so when the patch is git applied, the change log will be > discarded and won't appear in git. Ok, thx for the tips. > > eg. > > commit 6b465856936cb8f7eda31b20eb59fb5c8a19d468 > Author: Guo Ren <ren_guo@xxxxxxxxx> > Date: Tue Oct 2 16:43:18 2018 +0800 > > clocksource: add gx6605s SOC system timer > > The driver is for gx6605s SOC system timer and there are two > same timers in gx6605s. We use one for clkevt and another one for > clksrc. > > The timer is mmio map to access, so we need give mmio address in dts. > The counter at 0x0 offset is clock event. The counter at 0x40 offset is > clock source. > > Signed-off-by: Guo Ren <ren_guo@xxxxxxxxx> > Cc: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx> > --- > Changelog: > - pass checkpatch.pl > - Add COMIPLE_TEST in Kconfig > - no cast is needed for "struct clock_event_device *ce = dev" > - remove: extra space after (u64) > - Add License and Copyright > - Use timer-of framework > - Change name with upstream feedback > - Use clksource_mmio framework > --- Best Regards Guo Ren
