On Sun, 2018-10-14 at 18:52 -0700, Frank Rowand wrote: > On 10/14/18 18:06, Joe Perches wrote: > > On Sun, 2018-10-14 at 17:24 -0700, frowand.list@xxxxxxxxx wrote: > > > From: Frank Rowand <frank.rowand@xxxxxxxx> > > > > > > Add test case of two fragments updating the same property. After > > > adding the test case, the system hangs at end of boot, after > > > after slub stack dumps from kfree() in crypto modprobe code. [] > > I think this is worse performance than before. > > > > This now walks all entries when before it would > > return -EINVAL directly when it found a match. > > Yes, it is worse performance, but that is OK. > > This is a check that is done when a devicetree overlay is applied. > If an error occurs then that means that the overlay was incorrectly > specified. The file drivers/of/unittest-data/overlay_bad_add_dup_prop.dts > in this patch provides an example of how a bad overlay can be created. > > Once an error was detected, the check could return immediately, or it > could continue to give a complete list of detected errors. I chose to > give the complete list of detected errors. Swell. Please describe that in the commit message.
